IBM Sustainability Software - Ideas Portal


This portal is to open public enhancement requests against the products and services belonging to IBM Sustainability Software. To view all of your ideas submitted to IBM, create and manage groups of Ideas, or create an idea explicitly set to be either visible by all (public) or visible only to you and IBM (private), use the IBM Unified Ideas Portal (https://ideas.ibm.com).


Shape the future of IBM!

We invite you to shape the future of IBM, including product roadmaps, by submitting ideas that matter to you the most. Here's how it works:

Search existing ideas

Start by searching and reviewing ideas and requests to enhance a product or service. Take a look at ideas others have posted, and add a comment, vote, or subscribe to updates on them if they matter to you. If you can't find what you are looking for,

Post your ideas

  1. Post an idea.

  2. Get feedback from the IBM team and other customers to refine your idea.

  3. Follow the idea through the IBM Ideas process.


Specific links you will want to bookmark for future use

Welcome to the IBM Ideas Portal (https://www.ibm.com/ideas) - Use this site to find out additional information and details about the IBM Ideas process and statuses.

IBM Unified Ideas Portal (https://ideas.ibm.com) - Use this site to view all of your ideas, create new ideas for any IBM product, or search for ideas across all of IBM.

ideasibm@us.ibm.com - Use this email to suggest enhancements to the Ideas process or request help from IBM for submitting your Ideas.

Add a new idea Subscribe
Status Future consideration
Workspace IBM Engineering - Workflow Management
Categories Source Control
Created by Guest
Created on Feb 21, 2023

RELATED IDEAS

Code Review diff using wrong versions for comparison

The current design has taken into account multiple code review cycles effective v7.x since each Code Review cycle is now numbered i.e Code Review Cycle 1, Code Review Cycle 2, and so on. Therefore on the same logic the current Code Review diff comparison tool should have taken into account multiple code review cycles info consideration but it has not; this is a RFE or defect of paramount importance.

It is fundamental design for a Code Review tool to factor the possibility of multiple code review cycles and accordingly the Code Review UI diff tool must use the correct versions for comparison by default without manually correction intervention. This is how code reviews work within GitLab, Github, Apache Trace, Bitbucket etc.

Top 3 issues of current Code Review diff using wrong versions for comparison are outlined below:

1) Risk to reviewer relying on the wrong diff versions during a Code Review cycle since the Code Review diff is using wrong versions for comparison by default.

2) Development time loss and cost. Where the reviewer is aware of the default behaviour (ie Code Review diff use wrong versions for comparison by default), against each file the reviewer has to override and select the correct diff version. If there are 50 files being reviewing per user, if you multiple the correction effort by a factor of 50, this adds significantly to development time loss. Further we are an enterprise client, if you multiple this correction effort by 1000 developer then it further compounds to development time loss.

3) Some end users are not aware that the Code Review diff is using wrong versions for comparison by default and that manual correction is required. This further adds risks to poor code review quality being conducted due to defective default behaviour of the Code Review diff comparison tool.


As it stands, there is a logic gap as code multiple code review diff cycles should default to the latest. Until Idea is implemented, Is it possible to deactivate the multiple review cycles aspect in the mean time such that end users don't get into this potential trap of reviewing wrong version of file displayed by the code review review cycle?.


I hope that the engineering team would prioritize the implementation of this RFE or defect in timely manner.


Idea priority Urgent
Needed By Yesterday (Let's go already!)
  • Post comment
  • Guest
    Reply
    |     Feb 23, 2023
    The EWM Ideas Review board looked at this and decided to keep it on the Backlog as an uncommitted candidate for a future release.
  • Guest
    Reply
    |     Feb 21, 2023

    There is a logic gap as code multiple code review diff cycles should default to the latest.

    Until Idea is implemented, Is it possible to deactivate the multiple review cycles aspect in the mean time such that end users don't get into this potential trap of reviewing wrong version of file displayed by the code review review cycle?.

3 MERGED

Code Review UI diff using wrong versions for comparison

Merged
EWM Code Review effective v7.x is designed to take into account multiple code review cycles info consideration. However the Code Review UI diff use wrong versions for comparison if a file is involved in multiple Code Review cycle. It is of paramou...
about 2 years ago in IBM Engineering - Workflow Management / Source Control 1 Future consideration

By clicking the "Post Comment" or "Submit Idea" button, you are agreeing to the IBM Ideas Portal Terms of Use.
Do not place IBM confidential, company confidential, or personal information into any field.